D24400: Make hours qint64

Albert Astals Cid noreply at phabricator.kde.org
Fri Oct 4 19:44:40 BST 2019


aacid planned changes to this revision.
aacid added inline comments.

INLINE COMMENTS

> usta wrote in kformatprivate.cpp:339
> why dont we use quint64  in here ?

because its unnecessary, qint64 / number don't need a quint64 to store it.

> usta wrote in kformatprivate.cpp:470
> same problem here ( quint64 days and hours ) ( maybe not days but hours )
> also days, hours , minutes  and seconds also can be conts in here too

true, i wonder why the checker didn't complain for this one, will update

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D24400

To: aacid
Cc: usta, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191004/f0d219a1/attachment.html>


More information about the Kde-frameworks-devel mailing list