D24400: Make hours qint64
Ömer Fadıl Usta
noreply at phabricator.kde.org
Fri Oct 4 00:39:41 BST 2019
usta added inline comments.
INLINE COMMENTS
> kformatprivate.cpp:339
>
> - int hours = ms / MSecsInHour;
> + const qint64 hours = ms / MSecsInHour;
> ms = ms % MSecsInHour;
why dont we use quint64 in here ?
> kformatprivate.cpp:470
> quint64 ms = msecs;
> int days = ms / MSecsInDay;
> ms = ms % (MSecsInDay);
same problem here ( quint64 days and hours ) ( maybe not days but hours )
also days, hours , minutes and seconds also can be conts in here too
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D24400
To: aacid
Cc: usta, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191003/f6ff46a8/attachment.html>
More information about the Kde-frameworks-devel
mailing list