D24390: Add more file and directories to exclude filters
Carl Schwan
noreply at phabricator.kde.org
Thu Oct 3 16:52:07 BST 2019
ognarb added inline comments.
INLINE COMMENTS
> ngraham wrote in fileexcludefilters.cpp:137
> This one makes me a little nervous since it's a not-very-uncommon English word, not something implicitly technical that we can be safe excluding.
>
> Is there any other way we could exclude the contents of these folders? Maybe by filename, mimetype, or the naming of sub-folders?
This directory contains only pure PHP code, so not possible by filename or minetype. Maybe we could use the fact that a composer.json is always included in the same directory?
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D24390
To: ognarb, #baloo, ngraham
Cc: ngraham, kde-frameworks-devel, #baloo, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191003/1e61e213/attachment.html>
More information about the Kde-frameworks-devel
mailing list