D24390: Add more file and directories to exclude filters

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> fileexcludefilters.cpp:109
>  
>  const int s_defaultFileExcludeFiltersVersion = 5;
>  

Gotta bump this number whenever you change `s_defaultFileExcludeFilters`

> fileexcludefilters.cpp:137
>      "nbproject",
> +    "vendor", // composer installed php libs default directory
>  

This one makes me a little nervous since it's a not-very-uncommon English word, not something implicitly technical that we can be safe excluding.

Is there any other way we could exclude the contents of these folders? Maybe by filename, mimetype, or the naming of sub-folders?

> fileexcludefilters.cpp:147
>  
>  const int s_defaultFolderExcludeFiltersVersion = 2;
>  

Gotta bump this number whenever you change `s_defaultFolderExcludeFilters`

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D24390

To: ognarb, #baloo, ngraham
Cc: ngraham, kde-frameworks-devel, #baloo, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191003/5accdb1a/attachment.html>