D25590: support for user removing background and automatic shadow

[David Edmundson]

davidedmundson added a comment.


  That ended up quite nice in the end ++

INLINE COMMENTS

> appletinterface.cpp:414
>      emit backgroundHintsChanged();
> +    if (!m_userBackgroundHintsInitialized || !(m_backgroundHints & Plasma::Types::ConfigurableBackground)) {
> +        emit effectiveBackgroundHintsChanged();

I think technically has a bug.

if m_userBackgroundHintsInitialized == true

and the m_backgroundHints changed from !configurable -> configurable

then the effectiveBackgroundHints will change, but we're not emitting it.

i.e this should be

  if (!m_userBackgroundHintsInitialized || 
          !(newbackgroundHints & Plasma::Types::ConfigurableBackground))
          !(oldbackgroundHints & Plasma::Types::ConfigurableBackground)

Though personally I would just call effectiveBackgroundHints() before and after, it's more robust than duplicating the logic.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25590

To: mart, #plasma, davidedmundson
Cc: davidedmundson, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191128/d504f5f2/attachment.html>