<table><tr><td style="">davidedmundson added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D25590">View Revision</a></tr></table><br /><div><div><p>That ended up quite nice in the end ++</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D25590#inline-144423">View Inline</a><span style="color: #4b4d51; font-weight: bold;">appletinterface.cpp:414</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">emit</span> <span style="color: #004012">backgroundHintsChanged</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">m_userBackgroundHintsInitialized</span> <span style="color: #aa2211">||</span> <span style="color: #aa2211">!</span><span class="p">(</span><span class="n">m_backgroundHints</span> <span style="color: #aa2211">&</span> <span class="n">Plasma</span><span style="color: #aa2211">::</span><span class="n">Types</span><span style="color: #aa2211">::</span><span class="n">ConfigurableBackground</span><span class="p">))</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">emit</span> <span class="n">effectiveBackgroundHintsChanged</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I think technically has a bug.</p>

<p style="padding: 0; margin: 8px;">if m_userBackgroundHintsInitialized == true</p>

<p style="padding: 0; margin: 8px;">and the m_backgroundHints changed from !configurable -> configurable</p>

<p style="padding: 0; margin: 8px;">then the effectiveBackgroundHints will change, but we're not emitting it.</p>

<p style="padding: 0; margin: 8px;">i.e this should be</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">if (!m_userBackgroundHintsInitialized || 
        !(newbackgroundHints & Plasma::Types::ConfigurableBackground))
        !(oldbackgroundHints & Plasma::Types::ConfigurableBackground)</pre></div>

<p style="padding: 0; margin: 8px;">Though personally I would just call effectiveBackgroundHints() before and after, it's more robust than duplicating the logic.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework (Library)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D25590">https://phabricator.kde.org/D25590</a></div></div><br /><div><strong>To: </strong>mart, Plasma, davidedmundson<br /><strong>Cc: </strong>davidedmundson, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns<br /></div>