D25530: Sonnet: Add locales that are missing in QLocale

[Albert Astals Cid]

aacid added a comment.


  In D25530#567561 <https://phabricator.kde.org/D25530#567561>, @waqar wrote:
  
  > In D25530#567472 <https://phabricator.kde.org/D25530#567472>, @aacid wrote:
  >
  > > Any reason we particularly need this here instead of improving Qt?
  >
  >
  > Improving Qt is definitely the better and correct way. But in the meanwhile this can be temporarily fixed here and removed later when QLocale has all the ISO codes.
  >
  > There are a LOT more codes that aren't present in QLocale yet. I have just added the ones whose dictionaries I was able to find.
  
  
  Sorry but i don't think this is an acceptable solution, there's lots of other places in KDE code we use QLocale to get the name of a language, if you do this here you'll have to do the same in like 5 places.
  
  Instead just fix it in the proper place

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D25530

To: waqar
Cc: aspotashev, aacid, yurchor, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191126/b139c801/attachment.html>