D25440: Set a proper agent string for Attica requests

Dan Leinir Turthra Jensen noreply at phabricator.kde.org
Tue Nov 26 13:00:28 GMT 2019


leinir added inline comments.

INLINE COMMENTS

> davidedmundson wrote in provider.cpp:1632
> string.arg(foo, bar)
> 
> not
> 
> string.arg(foo).arg(bar)
> 
> otherwise we explode if foo contains the string "%1"

Oh dear, yes, quite - thanks :) Old habits die hard, got a few places that'll want doing in... various places, i'll have to take a look.

REPOSITORY
  R235 Attica

REVISION DETAIL
  https://phabricator.kde.org/D25440

To: leinir, #frameworks, #knewstuff, #plasma, starbuck, ronaldv
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191126/2f2d84be/attachment.html>


More information about the Kde-frameworks-devel mailing list