D25446: [kcoredirlister] Port away from QLinkedList

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kcoredirlister.cpp:1547
> +    QVector<ItemInUseChange> itemsToChange;
> +    itemsToChange.reserve(itemsInUse.size());
>      QSet<KCoreDirLister *> listers;

There can be a lot more items in `itemsInUse` than there will be in `itemsToChange`, due to the `if()` on line 1556. `itemsInUse` has all currently opened directories, while we care only about one here.
So I'm not sure about the `reserve()`. At least if we keep the `reserve()` we should `squeeze()` at the end.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25446

To: nicolasfella, #frameworks, dfaure
Cc: dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191121/10948269/attachment.html>