<table><tr><td style="">dfaure requested changes to this revision.<br />dfaure added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D25446">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D25446#inline-143794">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kcoredirlister.cpp:1547</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">Q<span class="bright">LinkedList</span></span><span style="color: #aa2211"><</span><span class="n">ItemInUseChange</span><span style="color: #aa2211">></span> <span class="n">itemsToChange</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">Q<span class="bright">Vector</span></span><span style="color: #aa2211"><</span><span class="n">ItemInUseChange</span><span style="color: #aa2211">></span> <span class="n">itemsToChange</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">itemsToChange</span><span class="p">.</span><span class="n">reserve</span><span class="p">(</span><span class="n">itemsInUse</span><span class="p">.</span><span class="n">size</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">QSet</span><span style="color: #aa2211"><</span><span class="n">KCoreDirLister</span> <span style="color: #aa2211">*></span> <span class="n">listers</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">There can be a lot more items in <tt style="background: #ebebeb; font-size: 13px;">itemsInUse</tt> than there will be in <tt style="background: #ebebeb; font-size: 13px;">itemsToChange</tt>, due to the <tt style="background: #ebebeb; font-size: 13px;">if()</tt> on line 1556. <tt style="background: #ebebeb; font-size: 13px;">itemsInUse</tt> has all currently opened directories, while we care only about one here.<br />
So I'm not sure about the <tt style="background: #ebebeb; font-size: 13px;">reserve()</tt>. At least if we keep the <tt style="background: #ebebeb; font-size: 13px;">reserve()</tt> we should <tt style="background: #ebebeb; font-size: 13px;">squeeze()</tt> at the end.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D25446">https://phabricator.kde.org/D25446</a></div></div><br /><div><strong>To: </strong>nicolasfella, Frameworks, dfaure<br /><strong>Cc: </strong>dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns<br /></div>