D21660: remove dbus for windows build and change audio dep logic

[Ralf Habacker]

habacker added a comment.


  In D21660#565113 <https://phabricator.kde.org/D21660#565113>, @cullmann wrote:
  
  > No, not really, I fixed that long ago, we auto-detect this and use the KDE_FORK_SLAVES code paths for that
  >
  > static bool forkSlaves()
  
  
  but this function is only called on Linux (https://github.com/KDE/kio/blob/a8de3cb2032aba3dc86b1c7a7e745ca000f21bf4/src/core/slave.cpp#L458), so my statement is still true.
  
    #ifdef Q_OS_UNIX
        if (forkSlaves() == 1) {
              ...
              QProcess::startDetached(kioslave, args);
    
            return slave;
        }
    #endif
  
  Later on there is the code, called on Windows, which requires klauncher
  
    QString errorStr;
      QDBusReply<int> reply = klauncher()->requestSlave(protocol, url.host(), slaveAddress.toString(), errorStr);
      if (!reply.isValid()) {
          error_text = i18n("Cannot talk to klauncher: %1", klauncher()->lastError().message());
          error = KIO::ERR_CANNOT_LAUNCH_PROCESS;
          delete slave;
          return 0;

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D21660

To: brute4s99, broulik, nicolasfella
Cc: cullmann, habacker, aspotashev, bcooksley, apol, nicolasfella, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191120/7286e22c/attachment.html>