D21660: remove dbus for windows build and change audio dep logic

[Christoph Cullmann]

cullmann added a comment.


  No, not really, I fixed that long ago, we auto-detect this and use the KDE_FORK_SLAVES code paths for that
  
  see in slave.cpp
  
    static bool forkSlaves()
    {
        // In such case we start the slave via QProcess.
        // It's possible to force this by setting the env. variable
        // KDE_FORK_SLAVES, Clearcase seems to require this.
        if (bForkSlaves.load() == -1) {
            bool fork = qEnvironmentVariableIsSet("KDE_FORK_SLAVES");
    
            // no dbus? => fork slaves as we can't talk to klauncher
            if (!fork) {
                fork = !QDBusConnection::sessionBus().interface();
            }
    
    #ifdef Q_OS_UNIX
            if (!fork) {
                // check the UID of klauncher
                QDBusReply<uint> reply = QDBusConnection::sessionBus().interface()->serviceUid(klauncher()->service());
                // if reply is not valid, fork, most likely klauncher can not be run or is not installed
                // fallback: if there's an klauncher process owned by a different user: still fork
                if (!reply.isValid() || getuid() != reply) {
                    fork = true;
                }
            }
    #endif
    
            bForkSlaves.testAndSetRelaxed(-1, fork ? 1 : 0);
        }
        return bForkSlaves.load() == 1;
    }

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D21660

To: brute4s99, broulik, nicolasfella
Cc: cullmann, habacker, aspotashev, bcooksley, apol, nicolasfella, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191120/a1193d70/attachment-0001.html>