D21235: Add handling of fuseiso filesystem type
David Hallas
noreply at phabricator.kde.org
Sun Nov 17 06:25:48 GMT 2019
hallas added inline comments.
INLINE COMMENTS
> bruns wrote in fstabhandling.cpp:301
> The API is totally awkward.
>
> You end up with something significantly cleaner when you create a new class for it:
>
> QStringMultiHash m_mtabCache;
> QHash<QString, QString> m_mtabFstypeCache;
> bool m_mtabCacheValid;
>
> and make the parser a member function.
>
> Then instantiate the class for the fuseiso case and for the globalFstabCache.
Yeah, I agree - it isn't the prettiest of code :D My main reasoning for doing it like this was to make the change as small as possible. But, let me take a stab at refactoring it a bit and push a new commit.
REPOSITORY
R245 Solid
REVISION DETAIL
https://phabricator.kde.org/D21235
To: hallas, bruns, ngraham
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191117/cdb2491d/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list