D25216: Fix translations of $GenericName

Méven Car noreply at phabricator.kde.org
Fri Nov 8 15:10:06 GMT 2019


meven created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  $GenericName was translated before being passed to KMoreToolsService::formatString,
  causing translators to process "$GenericName - ..." in their language, in turn causing formatString not to replace the expected placeholder $GenericName for instance.

TEST PLAN
  In another language than English:
  Open Dolphin
  Click on the free space progress bar
  Menu appears
  
  Before (with French) :
  First entry begins with "$NomGénérique -..."
  
  After:
  First entry begins with "Statistiques d'utilisation des disques - ..."

REPOSITORY
  R304 KNewStuff

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25216

AFFECTED FILES
  src/kmoretools/kmoretoolsmenufactory.cpp

To: meven
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191108/ba9f5c79/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list