D25067: Fix the header layouts for EntryDetails and Page components

Dan Leinir Turthra Jensen noreply at phabricator.kde.org
Tue Nov 5 12:31:21 GMT 2019


leinir added inline comments.

INLINE COMMENTS

> ahiemstra wrote in EntryDetails.qml:94
> Hmm, with the new toolbar code, there's actually little reason to use a custom delegate here, since the toolbar header already uses a title + tool buttons style. You could convert the three toolbuttons to actions and drop the rest of the delegate.

Ooh... you know, that's a very good idea :)

It'd be even better if we could work out how to do that with the bits on the front page as well... this /is/ intended to work for convergence and whatnot - but let's poke at that after we've got this bit sorted and such :)

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D25067

To: leinir, ngraham, #knewstuff, #frameworks, #plasma
Cc: ahiemstra, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191105/065660e2/attachment.html>


More information about the Kde-frameworks-devel mailing list