D25067: Fix the header layouts for EntryDetails and Page components

[Arjen Hiemstra]

ahiemstra added inline comments.

INLINE COMMENTS

> EntryDetails.qml:94
>      title: i18nc("Combined title for the entry details page made of the name of the entry, and the author's name", "%1 by %2").arg(component.name).arg(entryAuthor.name)
>      titleDelegate: QtLayouts.RowLayout {
> +        QtLayouts.Layout.fillWidth: true

Hmm, with the new toolbar code, there's actually little reason to use a custom delegate here, since the toolbar header already uses a title + tool buttons style. You could convert the three toolbuttons to actions and drop the rest of the delegate.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D25067

To: leinir, ngraham, #knewstuff, #frameworks, #plasma
Cc: ahiemstra, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191105/9db63c8f/attachment-0001.html>