D25039: Fix Clazy performance issues, const &
Méven Car
noreply at phabricator.kde.org
Fri Nov 1 15:31:34 GMT 2019
meven added a comment.
In D25039#557579 <https://phabricator.kde.org/D25039#557579>, @kossebau wrote:
> Not tested, only read code. Looks good to me.
> Please remove the newInstance method in a direct commit before, and drop change from this patch. (If you prefer, can do the remove commit as well myself)
I did test it. Maybe not with the exact last changeset. I will run the tests again before pushing juste to make sure.
Feel free to do the code removal, if I don't do it first, I will be afk for a few days, I will rebase on master the branch.
Btw I have already commited the changes to SlaveBase::configValue si it makes it to KF5.64 regardless of when this vers merged.
REPOSITORY
R241 KIO
BRANCH
arcpatch-D25039
REVISION DETAIL
https://phabricator.kde.org/D25039
To: meven, #frameworks, dfaure, kossebau
Cc: ahmadsamir, anthonyfieroni, kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191101/06ed3172/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list