D25039: Fix Clazy performance issues, const &

[Friedrich W. H. Kossebau]

kossebau accepted this revision.
kossebau added a comment.
This revision is now accepted and ready to land.


  Not tested, only read code. Looks good to me.
  Please remove the newInstance method in a direct commit before, and drop change from this patch. (If you prefer, can do the remove commit as well myself)

INLINE COMMENTS

> kcookieserver.h:106
>  private:
> -    virtual int newInstance(QList<QByteArray>)
> +    virtual int newInstance(const QList<QByteArray>&)
>      {

As there is no override changed in this patch, I found this suspicious and had a look:
seems this is dead code once introduced in 2002, when KCookieServer had been made a DCOP object, and KUniqueApplication asked subclasses to implement a virtual "int newInstance();" method.
See https://phabricator.kde.org/R446:1276fdc2bdbf7fd0236b8630cc1e529e3a6c4fe5

Nothing is using this method anymore now, so it can instead be simply removed, in a separate commit.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D25039

REVISION DETAIL
  https://phabricator.kde.org/D25039

To: meven, #frameworks, dfaure, kossebau
Cc: ahmadsamir, anthonyfieroni, kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191101/793b3fab/attachment.html>