D21354: Port to new connect syntax
Nathaniel Graham
noreply at phabricator.kde.org
Fri May 24 16:37:34 BST 2019
ngraham added a comment.
In D21354#469531 <https://phabricator.kde.org/D21354#469531>, @bruns wrote:
> LGTM
>
> currently, GCC thows some "0 for nullptr" and "missing override" warnings, are you going to address these (new SR)?
>
> Also, Qt recommends deriving from Q**Styled**ItemDelegate
Yeah there are a lot of warnings and more code cleanup needed, this is just the first of many. :)
REPOSITORY
R432 File Sharing (Samba) integration
REVISION DETAIL
https://phabricator.kde.org/D21354
To: ngraham, #frameworks, apol
Cc: bruns, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190524/f014048c/attachment.html>
More information about the Kde-frameworks-devel
mailing list