D21354: Port to new connect syntax

Stefan BrĂ¼ns noreply at phabricator.kde.org
Fri May 24 16:36:51 BST 2019


bruns added a comment.


  LGTM
  
  currently, GCC thows some "0 for nullptr" and "missing override" warnings, are you going to address these (new SR)?
  
  Also, Qt recommends deriving from Q**Styled**ItemDelegate

REPOSITORY
  R432 File Sharing (Samba) integration

REVISION DETAIL
  https://phabricator.kde.org/D21354

To: ngraham, #frameworks, apol
Cc: bruns, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190524/822646f9/attachment.html>


More information about the Kde-frameworks-devel mailing list