D20096: [WIP/help wanted] Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

Stefan BrĂ¼ns noreply at phabricator.kde.org
Sat Mar 30 15:38:25 GMT 2019


bruns added inline comments.

INLINE COMMENTS

> file.cpp:955
> +    // For FreeBSD and NetBSD, use st_birthtime. For OpenBSD,
> +    // use __st_birthtime.
> +

This comment is no longer relevant.

> kioslavetest.cpp:390
> +        case KIO::UDSEntry::UDS_CREATION_TIME:
> +            timestamp.setTime_t(entry.numberValue(*it));
> +            qDebug() << "CreationTime: " << timestamp.toString(Qt::SystemLocaleShortDate);

setTime_t is obsoleted by `fromSecsSinceEpoch()`

and actually, this is msecs, so use `QDateTime::fromMSecsSinceEpoch() static`

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20096

To: meven, #frameworks, dfaure, fvogt, bruns, broulik
Cc: ngraham, kde-frameworks-devel, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190330/fd744a44/attachment.html>


More information about the Kde-frameworks-devel mailing list