D20005: WIP: Find Qt5Widgets, required for Qt5::uic

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  In D20005#437029 <https://phabricator.kde.org/D20005#437029>, @cgiboudeaux wrote:
  
  > In D20005#436993 <https://phabricator.kde.org/D20005#436993>, @aacid wrote:
  >
  > > That not ideal, ki18n should be usable for projects that don't use widgets too.
  > >
  > > I'd say the bug is on the calling cmake side, if it has a ui file it must surely depend on widgets on the calling side, so just add it there?
  >
  >
  > Well, KF5I18nConfig.cmake includes KF5I18nMacros.cmake that requires Qt5Widgets.
  >
  > For a better visibility, I think adding this to KF5I18nConfig.cmake.in is better:
  >
  >   include(CMakeFindDependencyMacro)
  >   find_dependency(Qt5Widgets @REQUIRED_QT_VERSION@)
  >  
  >
  
  
  and in a different commit add
  
    find_dependency(Qt5Core @REQUIRED_QT_VERSION@)
  
  which is a public link target of ki18n

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D20005

To: aspotashev, #frameworks
Cc: cgiboudeaux, aacid, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190324/fc4ae122/attachment-0001.html>