D20005: WIP: Find Qt5Widgets, required for Qt5::uic
Christophe Giboudeaux
noreply at phabricator.kde.org
Sun Mar 24 08:42:32 GMT 2019
cgiboudeaux added a comment.
In D20005#436993 <https://phabricator.kde.org/D20005#436993>, @aacid wrote:
> That not ideal, ki18n should be usable for projects that don't use widgets too.
>
> I'd say the bug is on the calling cmake side, if it has a ui file it must surely depend on widgets on the calling side, so just add it there?
Well, KF5I18nConfig.cmake includes KF5I18nMacros.cmake that requires Qt5Widgets.
For a better visibility, I think adding this to KF5I18nConfig.cmake.in is better:
include(CMakeFindDependencyMacro)
find_dependency(Qt5Widgets @REQUIRED_QT_VERSION@)
REPOSITORY
R249 KI18n
REVISION DETAIL
https://phabricator.kde.org/D20005
To: aspotashev, #frameworks
Cc: cgiboudeaux, aacid, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190324/e6602347/attachment.html>
More information about the Kde-frameworks-devel
mailing list