D19778: [kitemmodels] make it compile without foreach

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> modelspy.cpp:323
>      d << "ModelSpy(";
> -    Q_FOREACH (const QVariantList &list, (QList<QVariantList>)(*modelSpy)) {
> +    const auto lst = (QList<QVariantList>)(*modelSpy);
> +    for (const QVariantList &list : lst) {

This is a good opportunity to remove this awful C cast.

  const QList<QVariantList> lst = *modelSpy;

> kbreadcrumbselectionmodel.cpp:167
>      Q_Q(KBreadcrumbSelectionModel);
>      QItemSelection deselectedCrumbs = getBreadcrumbSelection(deselected);
>      QItemSelection selectedCrumbs = getBreadcrumbSelection(selected);

const

> kbreadcrumbselectionmodel.cpp:168
>      QItemSelection deselectedCrumbs = getBreadcrumbSelection(deselected);
>      QItemSelection selectedCrumbs = getBreadcrumbSelection(selected);
>  

const

REPOSITORY
  R275 KItemModels

REVISION DETAIL
  https://phabricator.kde.org/D19778

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190316/88ef3994/attachment-0001.html>