<table><tr><td style="">dfaure requested changes to this revision.<br />dfaure added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D19778">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19778#inline-111124">View Inline</a><span style="color: #4b4d51; font-weight: bold;">modelspy.cpp:323</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">d</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">"ModelSpy("</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="bright"></span><span class="n"><span class="bright">Q_FOREACH</span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span style="color: #aa4000">const</span> <span class="bright"></span><span class="n"><span class="bright">QVariantList</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">&</span></span><span class="bright"></span><span class="n"><span class="bright">list</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span> <span class="p">(</span><span class="n">QList</span><span style="color: #aa2211"><</span><span class="n">QVariantList</span><span style="color: #aa2211">></span><span class="p">)(</span><span style="color: #aa2211">*</span><span class="n">modelSpy</span><span class="p">)<span class="bright">)</span></span><span class="bright"> </span><span class="p"><span class="bright">{</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">const</span> <span class="bright"></span><span style="color: #aa4000"><span class="bright">auto</span></span><span class="bright"> </span><span class="n"><span class="bright">lst</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span> <span class="p">(</span><span class="n">QList</span><span style="color: #aa2211"><</span><span class="n">QVariantList</span><span style="color: #aa2211">></span><span class="p">)(</span><span style="color: #aa2211">*</span><span class="n">modelSpy</span><span class="p">)<span class="bright">;</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">for</span> <span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">QVariantList</span> <span style="color: #aa2211">&</span><span style="color: #a0a000">list</span> <span class="p">:</span> <span class="n">lst</span><span class="p">)</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This is a good opportunity to remove this awful C cast.</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">const QList<QVariantList> lst = *modelSpy;</pre></div></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19778#inline-111126">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kbreadcrumbselectionmodel.cpp:167</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">Q_Q</span><span class="p">(</span><span class="n">KBreadcrumbSelectionModel</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">QItemSelection</span> <span class="n">deselectedCrumbs</span> <span style="color: #aa2211">=</span> <span class="n">getBreadcrumbSelection</span><span class="p">(</span><span class="n">deselected</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">QItemSelection</span> <span class="n">selectedCrumbs</span> <span style="color: #aa2211">=</span> <span class="n">getBreadcrumbSelection</span><span class="p">(</span><span class="n">selected</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">const</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19778#inline-111125">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kbreadcrumbselectionmodel.cpp:168</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">QItemSelection</span> <span class="n">deselectedCrumbs</span> <span style="color: #aa2211">=</span> <span class="n">getBreadcrumbSelection</span><span class="p">(</span><span class="n">deselected</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">QItemSelection</span> <span class="n">selectedCrumbs</span> <span style="color: #aa2211">=</span> <span class="n">getBreadcrumbSelection</span><span class="p">(</span><span class="n">selected</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">const</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R275 KItemModels</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D19778">https://phabricator.kde.org/D19778</a></div></div><br /><div><strong>To: </strong>mlaurent, dfaure<br /><strong>Cc: </strong>kde-frameworks-devel, michaelh, ngraham, bruns<br /></div>