D22157: Use debugging category in taglib extractor/writer

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> CMakeLists.txt:136
>      kde_enable_exceptions()
> -    ecm_add_test(taglibextractortest.cpp ../src/extractors/taglibextractor.cpp
> +    ecm_add_test(taglibextractortest.cpp ../src/extractors/taglibextractor.cpp ../src/kfilemetadata_debug.cpp
>          TEST_NAME "taglibextractortest"

use `${KfileMetaDataAutotest_SRCS}` instead ...

> CMakeLists.txt:153
>  
>      ecm_add_test(externalextractortest.cpp ../src/externalextractor.cpp ${KfileMetaDataAutotest_SRCS}
>              TEST_NAME "externalextractortest"

... like done here

> CMakeLists.txt:19
>  if(TAGLIB_FOUND)
> -    add_library(kfilemetadata_taglibextractor MODULE taglibextractor.cpp )
> +    add_library(kfilemetadata_taglibextractor MODULE taglibextractor.cpp ../kfilemetadata_debug.cpp)
>      target_include_directories(kfilemetadata_taglibextractor SYSTEM PRIVATE ${TAGLIB_INCLUDES})

please change the `ecm_declare_logging_category` in `src/CMakeLists.txt` to a distinct variable for the debug source file, and use it here.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D22157

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190629/d8564aa0/attachment.html>