<table><tr><td style="">bruns added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D22157">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22157#inline-124843">View Inline</a><span style="color: #4b4d51; font-weight: bold;">CMakeLists.txt:136</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> kde_enable_exceptions()
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> ecm_add_test(taglibextractortest.cpp ../src/extractors/taglibextractor.cpp
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> ecm_add_test(taglibextractortest.cpp ../src/extractors/taglibextractor.cpp<span class="bright"> ../src/kfilemetadata_debug.cpp</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> TEST_NAME "taglibextractortest"
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">use <tt style="background: #ebebeb; font-size: 13px;">${KfileMetaDataAutotest_SRCS}</tt> instead ...</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22157#inline-124844">View Inline</a><span style="color: #4b4d51; font-weight: bold;">CMakeLists.txt:153</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> ecm_add_test(externalextractortest.cpp ../src/externalextractor.cpp ${KfileMetaDataAutotest_SRCS}
</div><div style="padding: 0 8px; margin: 0 4px; "> TEST_NAME "externalextractortest"
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">... like done here</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22157#inline-124846">View Inline</a><span style="color: #4b4d51; font-weight: bold;">CMakeLists.txt:19</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">if(TAGLIB_FOUND)
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> add_library(kfilemetadata_taglibextractor MODULE taglibextractor.cpp )
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> add_library(kfilemetadata_taglibextractor MODULE taglibextractor.cpp <span class="bright">../kfilemetadata_debug.cpp</span>)
</div><div style="padding: 0 8px; margin: 0 4px; "> target_include_directories(kfilemetadata_taglibextractor SYSTEM PRIVATE ${TAGLIB_INCLUDES})
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">please change the <tt style="background: #ebebeb; font-size: 13px;">ecm_declare_logging_category</tt> in <tt style="background: #ebebeb; font-size: 13px;">src/CMakeLists.txt</tt> to a distinct variable for the debug source file, and use it here.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R286 KFileMetaData</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D22157">https://phabricator.kde.org/D22157</a></div></div><br /><div><strong>To: </strong>astippich, bruns<br /><strong>Cc: </strong>kde-frameworks-devel, Baloo, LeGast00n, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams<br /></div>