D22143: Add proper logging using ECMQtDeclareLoggingCategory

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> CMakeLists.txt:21
>  
> +   ${CMAKE_BINARY_DIR}/src/kactivities-stat-logsettings.cpp
> +

Instead of relying on an undocumented  cpp file name generated by ecm_qt_declare_logging_category, you rather want to have a separate SRC variable which carries the source files generated by the macro, and add its content here by instead adding this to the list:

  ${KActivitiesStats_LOG_SRCS}

That variable will also make it easier to track where this file is actually coming from, instead having to guess it.

> CMakeLists.txt:19
>  
> +ecm_qt_declare_logging_category(KActivitiesStats_LIB_SRCS
> +                                HEADER kactivities-stat-logsettings.h

As we want to reuse the source files also with the tests, better store in a separate var here, e.g. named `KActivitiesStats_LOG_SRCS`.
And add this manually to KActivitiesStats_LIB_SRCS and for the test as commented above:

  ecm_qt_declare_logging_category(KActivitiesStats_LOG_SRCS
                                  HEADER kactivities-stat-logsettings.h
                                  IDENTIFIER KACTIVITY_STAT_LOG
  CATEGORY_NAME kf5.kactivity.stat)
  list(APPEND KActivitiesStats_LIB_SRCS ${KActivitiesStats_LOG_SRCS})

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D22143

To: meven, ivan, #frameworks
Cc: kossebau, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190628/f0dbca64/attachment.html>