D22076: [KCM GridDelegate] Take into account implicitCellHeight for inner delegate height

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, mart.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  It only affected the `cellHeight` of the `GridView` but not the actual size of the delegate contents container inside.
  The `- 2 * gridUnit` undoes the `+ 2 * gridUnit` in the `GridView`'s default `implicitCellHeight`

TEST PLAN
  - Changed `view.implicitCellHeight` to some arbitrary value: had the cell delegate look perfect without the contents overflowing
  - Normal KCMs like icons still look fine

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D22076

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml

To: broulik, #plasma, mart
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190624/d91db877/attachment.html>