<table><tr><td style="">broulik created this revision.<br />broulik added reviewers: Plasma, mart.<br />Herald added a project: Frameworks.<br />Herald added a subscriber: kde-frameworks-devel.<br />broulik requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D22076">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>It only affected the <tt style="background: #ebebeb; font-size: 13px;">cellHeight</tt> of the <tt style="background: #ebebeb; font-size: 13px;">GridView</tt> but not the actual size of the delegate contents container inside.<br />
The <tt style="background: #ebebeb; font-size: 13px;">- 2 * gridUnit</tt> undoes the <tt style="background: #ebebeb; font-size: 13px;">+ 2 * gridUnit</tt> in the <tt style="background: #ebebeb; font-size: 13px;">GridView</tt>'s default <tt style="background: #ebebeb; font-size: 13px;">implicitCellHeight</tt></p></div></div><br /><div><strong>TEST PLAN</strong><div><ul class="remarkup-list">
<li class="remarkup-list-item">Changed <tt style="background: #ebebeb; font-size: 13px;">view.implicitCellHeight</tt> to some arbitrary value: had the cell delegate look perfect without the contents overflowing</li>
<li class="remarkup-list-item">Normal KCMs like icons still look fine</li>
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R296 KDeclarative</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D22076">https://phabricator.kde.org/D22076</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml</div></div></div><br /><div><strong>To: </strong>broulik, Plasma, mart<br /><strong>Cc: </strong>kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns<br /></div>