D21839: [TermGenerator] Use UTF-8 ByteArray for termList
Igor Poboiko
noreply at phabricator.kde.org
Sun Jun 16 18:13:33 BST 2019
poboiko added a comment.
Actually, there is an issue with that code right now, which I wanted to fix, but forgot.
The trimming part `finalArr = finalArr.mid(0, maxTermSize);` actually should be performed on `QString` instead of `QByteArray` - unicode symbols inside term can consist of two bytes, and cutting at `maxTermSize` bytes can actually cut half of symbols. I end up with terms like `тождественно�` inside `balooshow -x`.
Not to mention that russian terms end up being pretty small.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D21839
To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190616/bfe99766/attachment.html>
More information about the Kde-frameworks-devel
mailing list