D21788: Make Plasma::Svg::elementRect a bit leaner

Aleix Pol Gonzalez noreply at phabricator.kde.org
Fri Jun 14 13:54:25 BST 2019


apol marked an inline comment as done.
apol added inline comments.

INLINE COMMENTS

> bruns wrote in svg.cpp:123
> Are you sure you uploaded the right diff? No const static, Q_ASSERT ...

static isn't necessary, QRegularExpression already has internal regex compilation optimisations we can leverage.
Does the assert bother you?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21788

To: apol, #plasma, #frameworks
Cc: bruns, kde-frameworks-devel, LeGast00n, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190614/c93a4452/attachment.html>


More information about the Kde-frameworks-devel mailing list