D21788: Make Plasma::Svg::elementRect a bit leaner

Stefan BrĂ¼ns noreply at phabricator.kde.org
Fri Jun 14 13:05:18 BST 2019


bruns added inline comments.

INLINE COMMENTS

> svg.cpp:123
> +    QRegularExpression idExpr(QLatin1String("id\\s*?=\\s*?(['\"])(\\d+?-\\d+?-.*?)\\1"));
> +    Q_ASSERT(idExpr.isValid());
>  

Are you sure you uploaded the right diff? No const static, Q_ASSERT ...

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21788

To: apol, #plasma, #frameworks
Cc: bruns, kde-frameworks-devel, LeGast00n, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190614/ef784d2e/attachment.html>


More information about the Kde-frameworks-devel mailing list