D21577: [UnindexedFileIndexer] Skip filetime checks for new files

Stefan BrĂ¼ns noreply at phabricator.kde.org
Tue Jun 4 18:43:23 BST 2019


bruns added a comment.


  In D21577#474212 <https://phabricator.kde.org/D21577#474212>, @poboiko wrote:
  
  > I didn't know `QFileInfo` fetches information on demand (and caches it). That is the reason for this change, right?
  >  I think it would be nice to elaborate on that in summary, or maybe as a brief comment in the code.
  
  
  As far as I can see, the time is actually spent in converting from statbuf to QDateTime, and the underlying data is filled in when QFileInfo is instantiated in the QDirIterator.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21577

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190604/6a94946e/attachment.html>


More information about the Kde-frameworks-devel mailing list