D21577: [UnindexedFileIndexer] Skip filetime checks for new files

[Igor Poboiko]

poboiko added a comment.


  I didn't know `QFileInfo` fetches information on demand (and caches it). That is the reason for this change, right?
  I think it would be nice to elaborate on that in summary, or maybe as a brief comment in the code.

INLINE COMMENTS

> unindexedfileiterator.cpp:109
> +    } else {
> +        timeInfo = m_transaction->documentTimeInfo(fileId);
> +        if (timeInfo.mTime != fileInfo.lastModified().toSecsSinceEpoch()) {

Why do we need it here?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21577

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190604/b8cbc781/attachment.html>