D21519: Rename ImageMake and ImageModel properties

Stefan BrĂ¼ns noreply at phabricator.kde.org
Sun Jun 2 08:39:42 BST 2019


bruns added inline comments.

INLINE COMMENTS

> propertyinfo.cpp:185
> +            d->name = QStringLiteral("equipmentManufacturer");
> +            d->displayName = i18nc("@label EXIF", "Equipment Manufacturer");
>              d->valueType = QVariant::String;

Isn't `Manufacturer` sufficient for the label? Same for `Model`.

REPOSITORY
  R286 KFileMetaData

BRANCH
  euqipment_properties

REVISION DETAIL
  https://phabricator.kde.org/D21519

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190602/32d99727/attachment.html>


More information about the Kde-frameworks-devel mailing list