<table><tr><td style="">bruns added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D21519">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21519#inline-120995">View Inline</a><span style="color: #4b4d51; font-weight: bold;">propertyinfo.cpp:185</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">            <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">name</span> <span style="color: #aa2211">=</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"<span class="bright">imageMake</span>"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">            <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">displayName</span> <span style="color: #aa2211">=</span> <span class="n">i18nc</span><span class="p">(</span><span style="color: #766510">"@label EXIF"</span><span class="p">,</span> <span style="color: #766510">"<span class="bright">Image Make</span>"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">name</span> <span style="color: #aa2211">=</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"<span class="bright">equipmentManufacturer</span>"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">displayName</span> <span style="color: #aa2211">=</span> <span class="n">i18nc</span><span class="p">(</span><span style="color: #766510">"@label EXIF"</span><span class="p">,</span> <span style="color: #766510">"<span class="bright">Equipment Manufacturer</span>"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">            <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">valueType</span> <span style="color: #aa2211">=</span> <span class="n">QVariant</span><span style="color: #aa2211">::</span><span class="n">String</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Isn't <tt style="background: #ebebeb; font-size: 13px;">Manufacturer</tt> sufficient for the label? Same for <tt style="background: #ebebeb; font-size: 13px;">Model</tt>.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R286 KFileMetaData</div></div></div><br /><div><strong>BRANCH</strong><div><div>euqipment_properties</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D21519">https://phabricator.kde.org/D21519</a></div></div><br /><div><strong>To: </strong>astippich, ngraham, bruns<br /><strong>Cc: </strong>kde-frameworks-devel, Baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams<br /></div>