D17977: Improve reliability and semantic correctless of dupe test

[Tomaz Canabrava]

tcanabrava added inline comments.

INLINE COMMENTS

> dupetest.cpp:87-88
>          }
>          for (auto dir : ICON_DIRS) {
> -            dupesForDirectory(PROJECT_SOURCE_DIR + QStringLiteral("/") + dir);
> +            for (auto type : ICON_TYPES) {
> +                dupesForDirectory(PROJECT_SOURCE_DIR + QStringLiteral("/") + dir + QStringLiteral("/") + type);

const ref& ?

> dupetest.cpp:89
> +            for (auto type : ICON_TYPES) {
> +                dupesForDirectory(PROJECT_SOURCE_DIR + QStringLiteral("/") + dir + QStringLiteral("/") + type);
> +            }

QLatin1Char('/')

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17977

To: ngraham, #breeze, ndavis, GB_2
Cc: tcanabrava, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190118/e46a3a01/attachment.html>