D17977: Improve reliability and semantic correctless of dupe test
Nathaniel Graham
noreply at phabricator.kde.org
Sat Jan 5 04:12:05 GMT 2019
ngraham created this revision.
ngraham added reviewers: Breeze, ndavis, GB_2.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.
REVISION SUMMARY
This patch makes the `dupe` test only compare the actual icon directories, not everything in the target's build directory. This eliminates false positives and makes it run faster.
TEST PLAN
`ctest`
REPOSITORY
R266 Breeze Icons
BRANCH
dupe-test-reliability (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D17977
AFFECTED FILES
autotests/dupetest.cpp
autotests/testdata.h.cmake
To: ngraham, #breeze, ndavis, GB_2
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190105/8e81d905/attachment.html>
More information about the Kde-frameworks-devel
mailing list