D19421: WIP: [Icon Item] Block next animation also based on window visibility

Kai Uwe Broulik noreply at phabricator.kde.org
Thu Feb 28 14:31:15 GMT 2019


broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Plasma `Dialog` used to change the item's visiblity but this is no longer the case, so it would animate when a window is shown and the source has changed in the meantime.

TEST PLAN
  Changed volume, waited for OSD to disappear, changed brightness, OSD would no longer show while animating from the old pixmap.
  Changed volume, and changed brightness right away, OSD would still animate
  
  WIP because the first animation for each icon item isn't animated as the item is usually assigned a window which then becomes visible as such blocking the animation :/

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19421

AFFECTED FILES
  src/declarativeimports/core/iconitem.cpp
  src/declarativeimports/core/iconitem.h

To: broulik, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190228/1f1fa783/attachment.html>


More information about the Kde-frameworks-devel mailing list