<table><tr><td style="">broulik created this revision.<br />broulik added a reviewer: Plasma.<br />Herald added a project: Frameworks.<br />Herald added a subscriber: kde-frameworks-devel.<br />broulik requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D19421">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Plasma <tt style="background: #ebebeb; font-size: 13px;">Dialog</tt> used to change the item's visiblity but this is no longer the case, so it would animate when a window is shown and the source has changed in the meantime.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Changed volume, waited for OSD to disappear, changed brightness, OSD would no longer show while animating from the old pixmap.<br />
Changed volume, and changed brightness right away, OSD would still animate</p>
<p>WIP because the first animation for each icon item isn't animated as the item is usually assigned a window which then becomes visible as such blocking the animation :/</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework (Library)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D19421">https://phabricator.kde.org/D19421</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>src/declarativeimports/core/iconitem.cpp<br />
src/declarativeimports/core/iconitem.h</div></div></div><br /><div><strong>To: </strong>broulik, Plasma<br /><strong>Cc: </strong>kde-frameworks-devel, michaelh, ngraham, bruns<br /></div>