D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

Thomas Schöps noreply at phabricator.kde.org
Sun Feb 24 17:41:41 GMT 2019


thomassc added a comment.


  I think that this change will fix bug 403470 as well.
  
  Suggestion: in updateFontHeight()  in katerenderer.cpp, add a comment saying that the line height needs to match that which is used by Qt, since Qt may handle some parts of the drawing, e.g. selection backgrounds, and a mismatch will cause drawing issues. Perhaps also say where in the Qt code this can be looked up.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19283

To: cullmann, dhaumann
Cc: thomassc, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190224/ef7825ea/attachment.html>


More information about the Kde-frameworks-devel mailing list