<table><tr><td style="">thomassc added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D19283">View Revision</a></tr></table><br /><div><div><p>I think that this change will fix bug 403470 as well.</p>
<p>Suggestion: in updateFontHeight() in katerenderer.cpp, add a comment saying that the line height needs to match that which is used by Qt, since Qt may handle some parts of the drawing, e.g. selection backgrounds, and a mismatch will cause drawing issues. Perhaps also say where in the Qt code this can be looked up.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R39 KTextEditor</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D19283">https://phabricator.kde.org/D19283</a></div></div><br /><div><strong>To: </strong>cullmann, dhaumann<br /><strong>Cc: </strong>thomassc, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann<br /></div>