D19170: Fix crash while moving files

David Faure noreply at phabricator.kde.org
Sat Feb 23 19:30:47 GMT 2019


dfaure added a comment.


  I think it's an unwanted fact that the chmod job runs in parallel with the del job.
  A "return" after creating the chmod job would fix all this.
  
  But of course it should be possible to have two concurrent subjobs (one on dest, one on src), this whole issue just makes me realize that it makes the error handling more tricky ;-)
  
  If we want to keep these two running in parallel, we need to fix FileCopyJob to kill the running subjob when emitting the error from the other one.
  Would this fix it?
  http://www.davidfaure.fr/2019/filecopyjob.cpp.diff

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D19170

To: hallas, #frameworks, elvisangelaccio, dfaure
Cc: cfeck, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190223/251c3516/attachment.html>


More information about the Kde-frameworks-devel mailing list