D19170: Fix crash while moving files

[David Hallas]

hallas added a comment.


  In D19170#417274 <https://phabricator.kde.org/D19170#417274>, @dfaure wrote:
  
  > Let's find out :-)
  >
  > Note that SlaveBase already has a warning in case a slave emits finished() or error() twice; on the other hand this might not be the issue here, it could be the job itself being buggy (and then it would be in a single location).
  >  But yeah I'd recommend to start with checking if you see those SlaveBase warnings (in the debug output of the slave, not dolphin).
  
  
  I can see that it is because FileCopyJob spawns both a chmod job and then a del job, and then the chmod reports an error first and while we wait for the user feedback we receive an error from the del job and then report that, thereby violating the contract. In the beginning of the FileCopyJob::slotResult function there is a big error checking section where we check if we are moving, copying etc. but there is no check for chmod or delete and therefore it just ends in the emitResult case, so maybe we should put in a fix here as well?
  
  @dfaure - what do you think?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D19170

To: hallas, #frameworks, elvisangelaccio, dfaure
Cc: cfeck, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190222/a3304bb5/attachment.html>