D19001: katetextbuffer: refactor TextBuffer::save() to better separate code paths

Dominik Haumann noreply at phabricator.kde.org
Sat Feb 16 20:10:39 GMT 2019


dhaumann added a comment.


  In D19001#413694 <https://phabricator.kde.org/D19001#413694>, @cullmann wrote:
  
  > This looks reasonable, but could we get some Qt/KDE style CamelCase enum values?
  >
  > enum SaveResult {
  >
  >       SAVE_FAILED = 0,
  >       SAVE_NO_PERMS,
  >       SAVE_SUCCESS
  >   };
  
  
  You could even use an enum class:
  
    enum class SaveResult {
        Failed = 0,
        MissingPermissions,
        Success
    };

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19001

To: mgerstner, dhaumann, cullmann, #ktexteditor, chinmoyr, fvogt
Cc: kwrite-devel, kde-frameworks-devel, gennad, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190216/b98fc096/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list