D19001: katetextbuffer: refactor TextBuffer::save() to better separate code paths

Christoph Cullmann noreply at phabricator.kde.org
Sat Feb 16 15:38:43 GMT 2019


cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.


  This looks reasonable, but could we get some Qt/KDE style CamelCase enum values?
  
  enum SaveResult {
  
        SAVE_FAILED = 0,
        SAVE_NO_PERMS,
        SAVE_SUCCESS
    };

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19001

To: mgerstner, dhaumann, cullmann, #ktexteditor, chinmoyr, fvogt
Cc: kwrite-devel, kde-frameworks-devel, gennad, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190216/c640384c/attachment.html>


More information about the Kde-frameworks-devel mailing list