D19056: Tell people they should mostly be using KF5::AuthCore

Aleix Pol Gonzalez noreply at phabricator.kde.org
Sat Feb 16 00:43:11 GMT 2019


apol added a comment.


  Suggestion:
  
    or find KF5 with the Auth component in your CMakeLists.txt file. You need
    to link to KF5::AuthCore, or KF5::Auth if you need KAuth::ObjectDecorator.

INLINE COMMENTS

> README.md:17
>  
>  (or find KF5 with the Auth component) in your CMakeLists.txt file, and you need
> +to link to KF5::AuthCore (or KF5::Auth if you need KAuth::ObjectDecorator).

we could change the `, and` for a full stop so it's not a super long sentence?

> README.md:18
>  (or find KF5 with the Auth component) in your CMakeLists.txt file, and you need
> -to link to KF5::Auth.
> +to link to KF5::AuthCore (or KF5::Auth if you need KAuth::ObjectDecorator).
>  

I'd drop the parenthesis.

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D19056

To: aacid
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190216/e0bdd68b/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list