<table><tr><td style="">apol added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D19056">View Revision</a></tr></table><br /><div><div><p>Suggestion:</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">or find KF5 with the Auth component in your CMakeLists.txt file. You need
to link to KF5::AuthCore, or KF5::Auth if you need KAuth::ObjectDecorator.</pre></div></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19056#inline-106138">View Inline</a><span style="color: #4b4d51; font-weight: bold;">README.md:17</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span class="p">(</span><span class="n">or</span> <span class="n">find</span> <span class="n">KF5</span> <span style="color: #aa4000">with</span> <span class="n">the</span> <span class="n">Auth</span> <span class="n">component</span><span class="p">)</span> <span style="color: #aa4000">in</span> <span class="n">your</span> <span class="n">CMakeLists</span><span class="p">.</span><span class="n">txt</span> <span class="n">file</span><span class="p">,</span> <span class="n">and</span> <span class="n">you</span> <span class="n">need</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="n">to</span> <span class="n">link</span> <span class="n">to</span> <span class="n">KF5</span><span class="p">::</span><span class="n">Auth</span><span class="p">.</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="n">to</span> <span class="n">link</span> <span class="n">to</span> <span class="n">KF5</span><span class="p">::</span><span class="n">Auth<span class="bright">Core</span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">or</span></span><span class="bright"> </span><span class="n"><span class="bright">KF5</span></span><span class="bright"></span><span class="p"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">Auth</span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">if</span></span><span class="bright"> </span><span class="n"><span class="bright">you</span></span><span class="bright"> </span><span class="n"><span class="bright">need</span></span><span class="bright"> </span><span class="n"><span class="bright">KAuth</span></span><span class="bright"></span><span class="p"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">ObjectDecorator</span></span><span class="bright"></span><span class="p"><span class="bright">)</span>.</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">we could change the <tt style="background: #ebebeb; font-size: 13px;">, and</tt> for a full stop so it's not a super long sentence?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19056#inline-106137">View Inline</a><span style="color: #4b4d51; font-weight: bold;">README.md:18</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span class="p">(</span><span class="n">or</span> <span class="n">find</span> <span class="n">KF5</span> <span style="color: #aa4000">with</span> <span class="n">the</span> <span class="n">Auth</span> <span class="n">component</span><span class="p">)</span> <span style="color: #aa4000">in</span> <span class="n">your</span> <span class="n">CMakeLists</span><span class="p">.</span><span class="n">txt</span> <span class="n">file</span><span class="p">,</span> <span class="n">and</span> <span class="n">you</span> <span class="n">need</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="n">to</span> <span class="n">link</span> <span class="n">to</span> <span class="n">KF5</span><span class="p">::</span><span class="n">Auth</span><span class="p">.</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="n">to</span> <span class="n">link</span> <span class="n">to</span> <span class="n">KF5</span><span class="p">::</span><span class="n">Auth<span class="bright">Core</span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">or</span></span><span class="bright"> </span><span class="n"><span class="bright">KF5</span></span><span class="bright"></span><span class="p"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">Auth</span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">if</span></span><span class="bright"> </span><span class="n"><span class="bright">you</span></span><span class="bright"> </span><span class="n"><span class="bright">need</span></span><span class="bright"> </span><span class="n"><span class="bright">KAuth</span></span><span class="bright"></span><span class="p"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">ObjectDecorator</span></span><span class="bright"></span><span class="p"><span class="bright">)</span>.</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I'd drop the parenthesis.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R283 KAuth</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D19056">https://phabricator.kde.org/D19056</a></div></div><br /><div><strong>To: </strong>aacid<br /><strong>Cc: </strong>apol, kde-frameworks-devel, michaelh, ngraham, bruns<br /></div>