D18972: Format EXIF photo flash data

Alexander Stippich noreply at phabricator.kde.org
Tue Feb 12 21:22:58 GMT 2019


astippich added inline comments.

INLINE COMMENTS

> ngraham wrote in formatstrings.cpp:103
> Does this one mean "present but did not fire" or "there is no flash with this hardware"? If the latter, I might suggest instead "None". Otherwise this is fine the way it is.

Strictly this means that flash was disabled, not fired and that there is no hardware.
These are the strings GwenView and digiKam are using through libexiv2, and I think it makes sense not to deviate from this.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18972

To: astippich, ngraham
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190212/af478fe1/attachment.html>


More information about the Kde-frameworks-devel mailing list